Binary iidm: distinction between null and empty string #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
olperr1
requested changes
Jan 25, 2024
iidm/iidm-serde/src/test/java/com/powsybl/iidm/serde/BinaryTest.java
Outdated
Show resolved
Hide resolved
iidm/iidm-serde/src/test/java/com/powsybl/iidm/serde/BinaryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
olperr1
changed the title
|
olperr1
approved these changes
Jan 26, 2024
olperr1
pushed a commit
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> (cherry picked from commit 8441ed7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Empty string
""is written like a null String in the binary serialization.What is the new behavior (if this is a feature change)?
""is written by writing a zero length short in the binary serialization,Does this PR introduce a breaking change or deprecate an API?